WASI OTel Metrics #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Steurer <[email protected]>
Signed-off-by: Andrew Steurer <[email protected]>
Signed-off-by: Andrew Steurer <[email protected]>
Signed-off-by: Andrew Steurer <[email protected]>
Signed-off-by: Andrew Steurer <[email protected]>
Author
|
I think this PR should be focused on |
Signed-off-by: Andrew Steurer <[email protected]>
calebschoepp
requested changes
Oct 31, 2025
crates/factor-otel/src/host.rs
Outdated
Comment on lines
70
to
75
| Ok(Err("Shutdown has already been invoked".to_string())) | ||
| } | ||
| OTelSdkError::InternalFailure(e) => Ok(Err("Internal failure: ".to_string() + &e)), | ||
| OTelSdkError::Timeout(d) => Ok(Err(format!( | ||
| "Operation timed out after {} seconds", | ||
| d.as_secs() |
Owner
There was a problem hiding this comment.
Probably fine for now, but we'll need to think about the errors we expose to the guest. This strikes me as too much detail.
Author
There was a problem hiding this comment.
Just pushed some changes. Is this closer to what you have in mind?
Signed-off-by: Andrew Steurer <[email protected]>
Author
|
Sick. I don't have permission to merge. Do you mind? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the host implementation of
wasi-otel